Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 #1131

Merged
merged 110 commits into from
Jul 26, 2023
Merged

V6 #1131

merged 110 commits into from
Jul 26, 2023

Conversation

triarius
Copy link
Contributor

@triarius triarius commented Jun 9, 2023

Fixes: #998, #1096, #1027, #688, #792, #1156
Closes: #1103

I intend to make everything that follows part of the release announcement:

Draft Curated Changelog

v6.0.0 (2023-07-25)

Full Changelog

Changed

Added

Fixed

  • Guard against BUILDKITE_AGENT_ENABLE_GIT_MIRRORS not being set in startup script #1135 (@triarius)

Removed

  • Remove deprecated SpotPrice parameter #1130 (@triarius)
  • Removed packages. These packages are either not available on Amazon Linux 2023, or not installed by default on the base image we use. We have decided to not install them, as suitable replacements may be found.
    • Python 2
    • OpenSSL v1.0
    • AWS CLI v1
    • Docker-Compose v1
      • The docker-compose executable will prepend the --compatibility flag to docker-compose v2 #1148 (@triarius)
    • Cronie

Known Issues

  • If you invoke docker compose with the docker-compose command, the --compatibilty flag will be prepended for you. This will be the case with the docker-compose-buildkite-plugin unless you specify cli-version: 2 in your plugin config.
  • Docker build errors from docker compose will now exit with status code 17 or 18 when previously they would have exited with code 1. Please adjust your retry rules accordingly.
  • The docker group is now a system group. Previously, its group ID was hard-coded to be 1001, but now it could take some value from 999 descending. If you relied on the GID being hard-coded to 1001 in your builds, they may have permission errors. We recommend you use something like the bash expression getent group docker | awk -F: '{print $3}' to detect what the ID of the docker group is instead.

Python2 is long deprecates and is not in the amazon linux 2023 repos
Some tabs have to be kept because <<-HEREDOCs ignore tabs but not
spaces. Also standardise some spacing.
The http calls are nicer because we don't have to format the output with `cut`
It's meant to be installed locally, not on EC2 instances
triarius and others added 21 commits July 3, 2023 16:15
…ockerfilepostgres-on-bkbk-is-failing-and
# Conflicts:
#	packer/linux/scripts/install-buildkite-agent.sh
#	packer/windows/scripts/install-buildkite-agent.ps1
It's useful to use a different exit status when the environment hook
fails so that customers can build retry logic into their pipelines.
# Conflicts:
#	CHANGELOG.md
#	packer/linux/conf/bin/bk-install-elastic-stack.sh
#	packer/linux/scripts/install-buildkite-agent.sh
#	packer/windows/scripts/install-buildkite-agent.ps1
#	templates/aws-stack.yml
@triarius triarius marked this pull request as ready for review July 25, 2023 03:54
@triarius triarius requested a review from a team July 25, 2023 03:54
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work getting this shipped @triarius 🥳

@triarius triarius merged commit 419f271 into master Jul 26, 2023
@triarius triarius deleted the v6 branch July 26, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Update to Amazon Linux 2022
2 participants