-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python2 is long deprecates and is not in the amazon linux 2023 repos
aws-cli v2 automatically uses signature v4: https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingAWSSDK.html#UsingAWSSDK-move-to-Sig4
Some tabs have to be kept because <<-HEREDOCs ignore tabs but not spaces. Also standardise some spacing.
The http calls are nicer because we don't have to format the output with `cut`
It's meant to be installed locally, not on EC2 instances
…ockerfilepostgres-on-bkbk-is-failing-and
# Conflicts: # packer/linux/scripts/install-buildkite-agent.sh # packer/windows/scripts/install-buildkite-agent.ps1
…ker-compose-buildx-and-buildkite-agent
It's useful to use a different exit status when the environment hook fails so that customers can build retry logic into their pipelines.
…nvironment-hook-fails
# Conflicts: # CHANGELOG.md # packer/linux/conf/bin/bk-install-elastic-stack.sh # packer/linux/scripts/install-buildkite-agent.sh # packer/windows/scripts/install-buildkite-agent.ps1 # templates/aws-stack.yml
Bump buildkite-agent to v3.50.3
Correct grammar in an error message
…cts-between-v6-and-master
# Conflicts: # CHANGELOG.md
moskyb
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work getting this shipped @triarius 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #998, #1096, #1027, #688, #792, #1156
Closes: #1103
I intend to make everything that follows part of the release announcement:
Draft Curated Changelog
v6.0.0 (2023-07-25)
Full Changelog
Changed
main
andmaster
#1129 (@triarius)MaxSize
to be 0 #1140 (@triarius)InstanceType
toInstanceTypes
#1138 (@triarius)ManagedPolicyARN
toManagedPolicyARNs
#1138 (@triarius)SecurityGroupId
toSecurityGroupIds
#1128 (@triarius)EnableAgentGitMirrorsExperiment
toBuildkiteAgentEnableGitMirrors
#1123 (@triarius)ansi-timestamps
setting if and only ifBuildkiteAgentTimestampLines
parameter is"false"
#1132 (@triarius)Added
SpotAllocationStrategy
#1130 (@triarius)Fixed
BUILDKITE_AGENT_ENABLE_GIT_MIRRORS
not being set in startup script #1135 (@triarius)Removed
SpotPrice
parameter #1130 (@triarius)docker-compose
executable will prepend the--compatibility
flag to docker-compose v2 #1148 (@triarius)Known Issues
docker-compose
command, the--compatibilty
flag will be prepended for you. This will be the case with the docker-compose-buildkite-plugin unless you specifycli-version: 2
in your plugin config.17
or18
when previously they would have exited with code1
. Please adjust your retry rules accordingly.docker
group is now a system group. Previously, its group ID was hard-coded to be1001
, but now it could take some value from999
descending. If you relied on the GID being hard-coded to1001
in your builds, they may have permission errors. We recommend you use something like the bash expressiongetent group docker | awk -F: '{print $3}'
to detect what the ID of the docker group is instead.